nixos/binfmt: correctly handle argv0 when preserveArgvZero#118926
Closed
oxalica wants to merge 2 commits intoNixOS:masterfrom
Closed
nixos/binfmt: correctly handle argv0 when preserveArgvZero#118926oxalica wants to merge 2 commits intoNixOS:masterfrom
oxalica wants to merge 2 commits intoNixOS:masterfrom
Conversation
|
I marked this as stale due to inactivity. → More info |
Contributor
Author
|
Still relevant. |
This was referenced Oct 27, 2021
Contributor
Author
|
Close in favor of #143060, which is a superset of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently when
preserveArgvZerois enabled, the prepended argv0 is directly pass to QEMU asexec -- ${interpreter} "$@", which makes it actually interpreted as argv1.This PR fix the interpreter script to correctly pass argv0 to QEMU, only when the default QEMU
interpreteris used.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)